Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help output of hydra serve #1229

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

jayme-github
Copy link
Contributor

The help message is missing separation of public and admin port.

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

The help message is missing separation of public and admin port.

Signed-off-by: Janis Meybohm <[email protected]>
@aeneasr
Copy link
Member

aeneasr commented Dec 12, 2018

Thank you!

@aeneasr aeneasr merged commit a78050d into ory:master Dec 12, 2018
@jayme-github jayme-github deleted the fix_serve_help branch December 13, 2018 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants