Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ROTATED_SYSTEM_SECRET to old secret as speficied in docs. #1195

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Set ROTATED_SYSTEM_SECRET to old secret as speficied in docs. #1195

merged 1 commit into from
Dec 7, 2018

Conversation

prateek1192
Copy link
Contributor

@prateek1192 prateek1192 commented Nov 30, 2018

Related issue

#1187

Proposed changes

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please sign the DCO by doing git commit --amend -s && git push --force HEAD:<your-branch>.

@@ -141,7 +141,7 @@ ROTATED_SYSTEM_SECRET=%s hydra serve ...

If you wish that OAuth 2.0 Access and Refresh Tokens issued with the old secret are revoked, simply omit environment variable
ROTATED_SYSTEM_SECRET. This will NOT affect OpenID Connect ID Tokens!
`, newSecret)
`, oldSecret)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 138 variable ROTATED_SYSTEM_SECRET to the new secret: should also be variable ROTATED_SYSTEM_SECRET to the **OLD** secret:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @prateek1192 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aeneasr :)

@aeneasr
Copy link
Member

aeneasr commented Dec 7, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants