Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consent: Ignore row count in revoke #1173

Merged
merged 1 commit into from
Nov 16, 2018
Merged

consent: Ignore row count in revoke #1173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions consent/manager_sql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ WHERE challenge IN (SELECT r.challenge FROM hydra_oauth2_consent_request as r WH
}

func (m *SQLManager) RevokeUserAuthenticationSession(ctx context.Context, user string) error {
rows, err := m.db.ExecContext(
_, err := m.db.ExecContext(
ctx,
m.db.Rebind("DELETE FROM hydra_oauth2_authentication_session WHERE subject=?"),
user,
Expand All @@ -147,10 +147,13 @@ func (m *SQLManager) RevokeUserAuthenticationSession(ctx context.Context, user s
return sqlcon.HandleError(err)
}

count, _ := rows.RowsAffected()
if count == 0 {
return errors.WithStack(pkg.ErrNotFound)
}
// This confuses people, see https://github.com/ory/hydra/issues/1168
//
// count, _ := rows.RowsAffected()
// if count == 0 {
// return errors.WithStack(pkg.ErrNotFound)
// }

return nil
}

Expand Down