tracing: use context aware database methods #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amir Aslaminejad <[email protected]>
Signed-off-by: Amir Aslaminejad <[email protected]>
Signed-off-by: Amir Aslaminejad <[email protected]>
Signed-off-by: Amir Aslaminejad <[email protected]>
aaslamin
commented
Oct 4, 2018
| if err != nil { | ||
| return sqlcon.HandleError(err) | ||
| } | ||
|
|
||
| if _, err := m.db.Exec( | ||
| if _, err := tx.ExecContext( |
There was a problem hiding this comment.
This was a bug I believe. I fixed it since I was knee deep in the code at this point already.
m.db.Exec is not going to be done in the TX created above.
aaslamin
commented
Oct 4, 2018
| @@ -169,7 +171,7 @@ func (m *SQLManager) CreateForcedObfuscatedAuthenticationSession(ctx context.Con | |||
| return sqlcon.HandleError(err) | |||
| } | |||
|
|
|||
| if _, err := m.db.NamedExec( | |||
| if _, err := tx.NamedExec( | |||
|
Perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues on our efforts of context propagation by using the associated context aware methods in the sqlx package.
This is necessary for when we wrap the db driver with the tracing API, we will start getting spans out of the box 😉.
Furthermore, using these methods comes with the added benefit that database drivers that support context cancellation will be able to quit early if there is no hope of completing a query/tx.
Review: @aeneasr