Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oidc_context empty #900

Closed
androbi-com opened this issue Jun 4, 2018 · 4 comments · Fixed by #901
Closed

oidc_context empty #900

androbi-com opened this issue Jun 4, 2018 · 4 comments · Fixed by #901
Assignees
Labels
bug Something is not working. package/consent
Milestone

Comments

@androbi-com
Copy link
Contributor

Do you want to request a feature or report a bug?
bug

What is the current behavior?
In my authorization code flow I always get an empty member oidc_context in the structure consentReq as returned by

`consentReq, _, err := client.GetConsentRequest(challenge)`

which is called when handling the GET on /consent. Everything in consentReq seems fine, but oidc_context (in the json) which is empty.

oauth url:

https://localhost:9000/oauth2/auth?access_type=online&client_id=example-client&prompt=consent&response_type=code&scope=openid+email+profile+ex.quotes&state=somerandomstate&ui_locales=en+es

What is the expected behavior?
At least the ui_locales related data should be in there

Which version of the software is affected?
oryd/hydra:v1.0.0-beta.2-alpine

@aeneasr
Copy link
Member

aeneasr commented Jun 4, 2018

Are you using the in-memory store or the SQL one?

@androbi-com
Copy link
Contributor Author

in-memory

@aeneasr
Copy link
Member

aeneasr commented Jun 4, 2018

Ah yeah, it appears that this info is missing from the consent endpoint but available in the login endpoint due to a missing copy. Thank you for identifying and raising the issue!

@aeneasr aeneasr added bug Something is not working. package/consent labels Jun 4, 2018
@aeneasr aeneasr added this to the 1.0.0 milestone Jun 4, 2018
@aeneasr aeneasr self-assigned this Jun 4, 2018
aeneasr pushed a commit that referenced this issue Jun 4, 2018
This patch resolves an issue where oidc_context would be included in the login request but not the consent request.

Closes #900
@aeneasr
Copy link
Member

aeneasr commented Jun 4, 2018

Resolved with #901 . Congrats on raising the 900th issue :D

aeneasr pushed a commit that referenced this issue Jun 4, 2018
This patch resolves an issue where oidc_context would be included in the login request but not the consent request.

Closes #900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working. package/consent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants