Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading error message when using the SDK #686

Closed
mabruneau opened this issue Dec 7, 2017 · 1 comment
Closed

Misleading error message when using the SDK #686

mabruneau opened this issue Dec 7, 2017 · 1 comment
Labels
bug Something is not working. package/sdk

Comments

@mabruneau
Copy link

//
// ory/hydra/sdk/go/hydra/sdk.go:NewSDK
//
if c.ClientSecret == "" {
return nil, errors.New("Please specify a client id")
}
if c.ClientID == "" {
return nil, errors.New("Please specify a client secret")
}
@aeneasr
Copy link
Member

aeneasr commented Dec 8, 2017

Would you mind creating a PR?

@aeneasr aeneasr added bug Something is not working. package/sdk labels Dec 8, 2017
aeneasr pushed a commit that referenced this issue Dec 14, 2017
sdk/go: Resolves incorrect error message
5a9d236 
Closes #686
@aeneasr aeneasr mentioned this issue Dec 14, 2017
Merged
aeneasr pushed a commit that referenced this issue Dec 14, 2017
@arekkas
sdk/go: Resolves incorrect error message (#713)
1290660 
Closes #686
@snyk-bot snyk-bot mentioned this issue Dec 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working. package/sdk
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeneasr @mabruneau