Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

policies: validate conditions and return error instead of silently dropping them #350

Closed
olivierdeckers opened this issue Jan 4, 2017 · 1 comment
Closed

policies: validate conditions and return error instead of silently dropping them #350

olivierdeckers opened this issue Jan 4, 2017 · 1 comment
Labels
bug Something is not working. upstream Issue is caused by an upstream dependency.
Milestone
0.10.0

Comments

@olivierdeckers
Copy link
Contributor

Currently, non-existing conditions are silently dropped from the policy, and the policy is created. It would be better if hydra returned an error and did not create the policy at all.
@aeneasr aeneasr added the bug Something is not working. label Jan 4, 2017
@aeneasr aeneasr changed the title Policies: validate conditions and return error instead of silently dropping them policies: validate conditions and return error instead of silently dropping them Jan 4, 2017
@aeneasr aeneasr mentioned this issue Jan 4, 2017
Closed
@aeneasr
Copy link
Member

aeneasr commented Jan 4, 2017

upstream: ory/ladon#45

@aeneasr aeneasr added the upstream Issue is caused by an upstream dependency. label Jan 4, 2017
@aeneasr aeneasr added this to the 1.0.0: stable release milestone Jun 5, 2017
@aeneasr aeneasr added the policy label Jun 5, 2017
aeneasr pushed a commit that referenced this issue Jun 6, 2017
vendor: upgrade to ladon 0.7.4 - closes #350
2a5cac3
@aeneasr aeneasr closed this as completed in 874c62d Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working. upstream Issue is caused by an upstream dependency.
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
2 participants
@olivierdeckers @aeneasr