Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration docs link is incorrect in hydra serve --help #1486

Closed
goknsh opened this issue Jul 10, 2019 · 3 comments · Fixed by #1488
Closed

Configuration docs link is incorrect in hydra serve --help #1486

goknsh opened this issue Jul 10, 2019 · 3 comments · Fixed by #1488

Comments

@goknsh
Copy link

goknsh commented Jul 10, 2019

Describe the bug

Link to configuration documentation when running hydra serve --help shows a link to: https://github.com/ory/hydra/blob/v1.0.0+oryOS.12/docs/config.yaml, which leads to a 404 page.

Reproducing the bug

Steps to reproduce the behavior:

  1. Install Hydra with:
$ curl https://raw.githubusercontent.com/ory/hydra/master/install.sh | bash -s -- -b .
  1. Run command to view help info:
$ ./hydra serve --help

Expected behavior
See serve.go:
Looks like the URL for config documentation is being generate using the installed Version.

It should instead use the commit for the installed Version.
So if the error is corrected, the correct URL would be:
https://github.com/ory/hydra/blob/<commit>/docs/config.yaml

@goknsh goknsh changed the title Configuration docs link is incorrect in hydra serve --help Configuration docs link is incorrect in hydra serve --help Jul 10, 2019
@aeneasr
Copy link
Member

aeneasr commented Jul 10, 2019

Nice catch! Would you be up for a PR?

@goknsh
Copy link
Author

goknsh commented Jul 10, 2019

I am going to try.

@goknsh
Copy link
Author

goknsh commented Jul 10, 2019

I think changing Version to Commit should work, but I am unsure and could not setup the Hydra development environment to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants