Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consent: Login and consent request challenge should be sent as query parameter #1307

Closed
aeneasr opened this issue Mar 12, 2019 · 1 comment
Closed

consent: Login and consent request challenge should be sent as query parameter #1307

aeneasr opened this issue Mar 12, 2019 · 1 comment
Assignees
@aeneasr
Labels
feat New feature or request. package/consent
Milestone
v1.0.0

Comments

@aeneasr
Copy link
Member

aeneasr commented Mar 12, 2019

Currently, the consent request is consumed as a path parameter. This can cause issues when the parameter is not properly parsed at the login or consent app: https://consent/consent?challenge=../foo will cause the consent app to make the request to the wrong endpoint if challenge is not properly escaped.
@aeneasr aeneasr added feat New feature or request. package/consent labels Mar 12, 2019
@aeneasr aeneasr added this to the v1.0.0 milestone Mar 12, 2019
@aeneasr aeneasr self-assigned this Mar 12, 2019
aeneasr added a commit that referenced this issue Apr 11, 2019
@aeneasr
consent: Use query parameters for challenges
459ae6a 
Closes #1307

Signed-off-by: aeneasr <[email protected]>
@toddams
Copy link

toddams commented Apr 24, 2019

Seems like api doc is not up to date. It still shows it as path parameter

@RazerM RazerM mentioned this issue May 17, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
feat New feature or request. package/consent
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@aeneasr @toddams