Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: Deleting a client should delete all associated data too #1131

Closed
8 tasks
aeneasr opened this issue Oct 26, 2018 · 1 comment
Closed
8 tasks

client: Deleting a client should delete all associated data too #1131

aeneasr opened this issue Oct 26, 2018 · 1 comment
Labels
bug Something is not working. feat New feature or request. package/client package/oauth2
Milestone
v1.0.0-rc.1

Comments

@aeneasr
Copy link
Member

aeneasr commented Oct 26, 2018 •
edited
Loading

Right now no tokens are deleted when deleting a client:

  • Handled consent requests
  • Consent requests
  • Handled login requests (maybe)
  • Login requests (maybe)
  • Authorize codes
  • Refresh tokens
  • Access tokens (implicit, PKCE, ...)
  • OIDC Flows
@aeneasr aeneasr added this to the v1.0.0-rc.1 milestone Oct 26, 2018
@aeneasr aeneasr mentioned this issue Nov 3, 2018
Closed
@aeneasr aeneasr added the bug Something is not working. label Nov 3, 2018
@aeneasr
Copy link
Member Author

aeneasr commented Nov 8, 2018

We need to provide a migration that purges old data with broken consistency before applying this. Could be part of the migration, would need a big fat warning before applying it because some clients might lose access.

aeneasr pushed a commit that referenced this issue Nov 18, 2018
consent: Add foreign key migrations
573ceec 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
consent: Make tests compatible with foreign keys
172c768 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
cmd: Force migration order
fee8a4a 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
client: Improve migration test suite
b906081 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
sql: Improve migration tests
d623d88 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
oauth2: Add foreign keys
cca7733 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
sql: Clean up foreign key work
5b912d2 
Closes #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
consent: Add foreign key migrations
6712cfe 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
consent: Make tests compatible with foreign keys
8c7fe96 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
cmd: Force migration order
f0a1baf 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
client: Improve migration test suite
cd234c7 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
sql: Improve migration tests
c545cf6 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
oauth2: Add foreign keys
970c1ae 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
sql: Clean up foreign key work
8ccd027 
Closes #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
consent: Add foreign key migrations
d194211 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
consent: Make tests compatible with foreign keys
fcb7019 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
cmd: Force migration order
e152f75 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
client: Improve migration test suite
9a237db 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
sql: Improve migration tests
3cf9f5f 
See #1131

Signed-off-by: arekkas <[email protected]>
aeneasr pushed a commit that referenced this issue Nov 18, 2018
oauth2: Add foreign keys
604051b 
See #1131

Signed-off-by: arekkas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working. feat New feature or request. package/client package/oauth2
Projects
None yet
Milestone
v1.0.0-rc.1
Development

No branches or pull requests
1 participant
@aeneasr