Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe OIDC for native apps #1379

Merged
merged 2 commits into from
Apr 27, 2023
Merged

docs: describe OIDC for native apps #1379

merged 2 commits into from
Apr 27, 2023

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Apr 25, 2023

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great already, just some minor things.

@vinckr vinckr requested a review from kmherrmann as a code owner April 27, 2023 12:43
@vinckr vinckr enabled auto-merge (squash) April 27, 2023 12:43
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vinckr vinckr merged commit a69e1c1 into master Apr 27, 2023
@vinckr vinckr deleted the hperl/app-oidc branch April 27, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants