fix(query): regression that breaks TData type check when using custom mutation
#1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soartec-lab
force-pushed
the
fix/react-query/regression-tdata-generic-type
branch
from
a37ce0b to
2f1eabf
Compare
soartec-lab
added
bug
melloware
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
fix #1820
This is a revert of #1735.
#1805 was also partially reverted, but I did a complete revert with this PR.
In #1735, we tried to improve type safety, but it seems like we made a bug. I'm not expecting this problem, so I'll revert it.
Related PRs
Todos
Steps to Test or Reproduce
You can check by tests and sample apps