Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always store script pubkey in output table #4254

Merged
merged 9 commits into from
Mar 6, 2025
Merged

Always store script pubkey in output table #4254

merged 9 commits into from
Mar 6, 2025

Conversation

raphjaph
Copy link
Collaborator

@raphjaph raphjaph commented Mar 4, 2025

No description provided.

casey
casey requested changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, but I think it needs a test, and we need to profile index time and index size. I think this is probably fine but we need to understand the impact of doing it.

@raphjaph raphjaph changed the base branch from master to bdk March 4, 2025 21:54
@raphjaph raphjaph changed the base branch from bdk to master March 4, 2025 22:27
@raphjaph raphjaph changed the base branch from master to bdk March 5, 2025 01:37
casey
casey approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphjaph raphjaph enabled auto-merge (squash) March 6, 2025 01:22
@raphjaph raphjaph merged commit bf841a3 into ordinals:bdk Mar 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casey casey casey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphjaph @casey