Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ParsedEnvelope and Envelope public #4249

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Conversation

NCrashed
Copy link
Contributor

Fix #4246, the PR allows people to access ParsedEnvelope::from_transaction for parsing inscriptions from their Rust code.

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please run cargo fmt --all to fix the linter error in CI. Normally I would just fix it but I can't push to your master branch.

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please allow maintainers to make changes to this branch?

The branch needs to be updated with the latest changes from master.

@NCrashed
Copy link
Contributor Author

NCrashed commented Mar 5, 2025

I have sent you invite to the fork access.

P.S. If I misunderstand what exactly was meant, please tell where to find the required Github feature to allow upstream maintainers access.

@raphjaph
Copy link
Collaborator

raphjaph commented Mar 5, 2025

Normally there should be a check box in the bottom right that allows maintainers to make changes to branches on PRs. It should usually be on by default. Maybe if you open the PR from a feature branch instead of master it works.

Screenshot 2025-03-05 at 23 46 49

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphjaph raphjaph enabled auto-merge (squash) March 5, 2025 22:55
@raphjaph raphjaph merged commit 7e96b24 into ordinals:master Mar 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ParsedEnvelop::from_transaction public
2 participants