-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(client): Debug, Eq, Hash, PartialEq for ImageLayer; convert annotations to BTreeMap #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change here! One comment around changing the type and just breaking the API
Signed-off-by: Vaughn Dice <[email protected]>
ef3d433
to
3eb6340
Compare
3eb6340
to
48f5ebc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work here! @flavio would like your review too before I merge since this is a breaking API change.
@vdice heads up that it looks like the BTreeMap import didn't get picked up in the windows build for some reason |
48f5ebc
to
30a608e
Compare
@thomastaylor312 thanks - looks like I didn't update the import in examples/wasm/push.rs. Now updated; hopefully that was the issue. edit: nope; still failing... looking edit 2: okay, needed to update examples/wasm/main.rs as well. Weird - nothing complained when I ran my usual |
- eliminates the need for a specific Hash impl for ImageLayer Signed-off-by: Vaughn Dice <[email protected]>
30a608e
to
dfe6d40
Compare
Sorry, I was on vacation. This change looks good to me |
Thanks so much @thomastaylor312 and @flavio! |
Changeset motivated by the need to differentiate and deduplicate collections of ImageLayers.