Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error message of path traversing #979

Closed
wants to merge 2 commits into from

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Jun 20, 2023

What this PR does / why we need it:
This PR provides detailed instruction to user on how to handle path traversing error during pulling.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #978

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #979 (a05ce01) into main (22a7316) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
- Coverage   81.08%   80.99%   -0.10%     
==========================================
  Files          53       53              
  Lines        2776     2778       +2     
==========================================
- Hits         2251     2250       -1     
- Misses        356      358       +2     
- Partials      169      170       +1     
Impacted Files Coverage Δ
cmd/oras/root/pull.go 73.62% <0.00%> (-1.38%) ⬇️

@qweeah qweeah marked this pull request as draft June 20, 2023 02:59
@qweeah
Copy link
Contributor Author

qweeah commented Jun 20, 2023

Making this a draft since #980 might be a better option.

@qweeah qweeah closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve path traversal error msg of oras pull
2 participants