test: add unit-tests for internal/version.go
#977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enraiha0307
requested review from
sajayantony,
shizhMSFT,
SteveLasker,
qweeah and
TerryHowe
as code owners
Signed-off-by: Akanksha Gahalot <[email protected]>
enraiha0307
force-pushed
the
version-file-code-coverage
branch
from
254571b to
01fc19f
Compare
TerryHowe
requested changes
Jun 19, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #977 +/- ##
==========================================
+ Coverage 81.08% 81.19% +0.10%
==========================================
Files 53 53
Lines 2776 2776
==========================================
+ Hits 2251 2254 +3
+ Misses 356 354 -2
+ Partials 169 168 -1 |
Signed-off-by: Akanksha Gahalot <[email protected]>
|
@TerryHowe I've done the requested changes, please review. |
qweeah
reviewed
Jun 20, 2023
qweeah
reviewed
Jun 20, 2023
qweeah
reviewed
Jun 20, 2023
Signed-off-by: Akanksha Gahalot <[email protected]>
|
@qweeah review comments resolved, please review. |
shizhMSFT
changed the title
internal/version.go
qweeah
approved these changes
Jun 21, 2023
|
Yes, I'll do that. |
This was referenced Jul 5, 2023
shizhMSFT
pushed a commit
to shizhMSFT/oras
that referenced
this pull request
Aug 3, 2023
Signed-off-by: Akanksha Gahalot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a unit test file for
internal/version/version.goto increase its code coverage from 40% to 100%.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
This PR is a small part of #972
Please check the following list: