[GR-62586] Fix transient Time.new specs #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix building a new Time instance with naively increased hours by 1: ```ruby Time.new(..., t.hour + 1, ...) ``` It leads to hours overflowing (becoming greater than 23) and transient failures like the following ones: ``` 1) Time.now Timezone object returned value by #utc_to_local and #local_to_utc methods could be Time instance ERROR ArgumentError: argument out of range 2) Time.now Timezone object returned value by #utc_to_local and #local_to_utc methods could be Time subclass instance ERROR ArgumentError: argument out of range ```
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.