Bump cryptography from 3.2.1 to 3.3.2

[dependabot]

Bumps cryptography from 3.2.1 to 3.3.2.

Changelog

Sourced from cryptography's changelog.

3.3.2 - 2021-02-07

* **SECURITY ISSUE:** Fixed a bug where certain sequences of ``update()`` calls
  when symmetrically encrypting very large payloads (>2GB) could result in an
  integer overflow, leading to buffer overflows. *CVE-2020-36242*
.. _v3-3-1:
3.3.1 - 2020-12-09

• Re-added a legacy symbol causing problems for older pyOpenSSL users.

.. _v3-3:

3.3 - 2020-12-08

* **BACKWARDS INCOMPATIBLE:** Support for Python 3.5 has been removed due to
  low usage and maintenance burden.
* **BACKWARDS INCOMPATIBLE:** The
  :class:`~cryptography.hazmat.primitives.ciphers.modes.GCM` and
  :class:`~cryptography.hazmat.primitives.ciphers.aead.AESGCM` now require
  64-bit to 1024-bit (8 byte to 128 byte) initialization vectors. This change
  is to conform with an upcoming OpenSSL release that will no longer support
  sizes outside this window.
* **BACKWARDS INCOMPATIBLE:** When deserializing asymmetric keys we now
  raise ``ValueError`` rather than ``UnsupportedAlgorithm`` when an
  unsupported cipher is used. This change is to conform with an upcoming
  OpenSSL release that will no longer distinguish between error types.
* **BACKWARDS INCOMPATIBLE:** We no longer allow loading of finite field
  Diffie-Hellman parameters of less than 512 bits in length. This change is to
  conform with an upcoming OpenSSL release that no longer supports smaller
  sizes. These keys were already wildly insecure and should not have been used
  in any application outside of testing.
* Updated Windows, macOS, and ``manylinux`` wheels to be compiled with
  OpenSSL 1.1.1i.
* Python 2 support is deprecated in ``cryptography``. This is the last release
  that will support Python 2.
* Added the
  :meth:`~cryptography.hazmat.primitives.asymmetric.rsa.RSAPublicKey.recover_data_from_signature`
  function to
  :class:`~cryptography.hazmat.primitives.asymmetric.rsa.RSAPublicKey`
  for recovering the signed data from an RSA signature.
.. _v3-2-1:

Commits

• 82b6ce2 correct buffer overflows cause by integer overflow in openssl (#5747)
• 1ff0d50 re-add Cryptography_HAS_TLSEXT_HOSTNAME and bump for 3.3.1 (#5625)
• 7e8fff7 Prepare for 3.3 release (#5603)
• b5278c9 Fixed DH tests for latest CentOS FIPS OpenSSL (#5604)
• 6693d55 Add support for RSA signature recovery (#5573)
• 8686d52 Document that PKCS1v1.5 is not constant time (#5600)
• 1be144a bump cffi minimum version to help out pyopenssl (#5598)
• 96f2d96 remove legacy debugging code from setup.py (#5597)
• 2660f93 Document that Firefox doesn't support unencrypted pkcs12 (#5596)
• a209669 Added tls bindings for new OpenSSL APIs (#5595)
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

[bhagwatvyas]

We’ve made the change internally and are testing, and will release once our tests pass.

[bhagwatvyas]

We have decided to hold off on upgrading cryptography until around end of May, 2021. The reasoning is as follows:
The security vulnerability is described as
In the cryptography package before 3.3.2 for Python, certain sequences of update calls to symmetrically encrypt multi-GB values could result in an integer overflow and buffer overflow, as demonstrated by the Fernet class.

1. The Python SDK uses asymmetric encryption for all calls except for Client Side Encryption. This vulnerability affects symmetric encryption only.
2. The GitHub issue which reported this vulnerability specifically mentions the Fernet class. The OCI Python SDK does not use this class. From our analysis, we believe that it should not affect the calls using Client Side Encryption, but based on the CVE description being slightly ambiguous as to what is affected (“as demonstrated by the Fernet class” does not strictly mean only the Fernet class has the issue), we cannot be 100% sure.
3. Our data shows only a small amount of usage of Client Side Encryption in the OCI Python SDK.
4. Cryptography version 3.3.2 does not support Python 3.5. Upgrading to cryptography version 3.3.2 immediately would give customers using the OCI CLI with Python 3.5 little notice to upgrade their Python version (OCI CLI uses the OCI Python SDK underneath). The OCI CLI plans to drop support for Python 3.5 on May 25th, 2021. More details here: Python 2.7/3.5 Deprecation oci-cli#377

[pedworthy-r7]

While I appreciate that the vulnerability may not effect your use-case for the library it becomes problematic if a project that uses OCI also uses the symmetric encryption portion of the cryptography package. Would it be possible to change from pinning it to 3.2.1 to >=3.2.1? This wouldn't drop support for python 3.5, if that is needed the importing project is using 3.5 pip will continue to use a version before 3.3.2. It will allow projects that don't need 3.5 support and have need for the fix to
CVE-2020-36242 to set their dependency to force cryptography to version 3.3.2 or higher.

[bhagwatvyas]

@pedworthy-r7 thank you for bringing this to our attention. We're considering your proposal to unpin cryptography and we are testing the change on supported python versions of OCI Python SDK and OCI CLI.
In the meanwhile, if someone requires immediate resolution then you can fork this project and change cryptography to higher versions at two places:

1. setup.py - https://github.com/oracle/oci-python-sdk/blob/master/setup.py#L35.
2. requirements.txt - https://github.com/oracle/oci-python-sdk/blob/master/requirements.txt#L5

The instructions for setting up the repo and building the wheel are mentioned here - https://github.com/oracle/oci-python-sdk/blob/master/README-development.rst

[bhagwatvyas]

Closing this PR as cryptography has been upgraded to 3.3.2

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.