Action link localization #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to rebase once the #824 is merged |
hishamco
commented
Oct 19, 2020
| @@ -93,6 +95,7 @@ | |||
|
|
|||
| } | |||
|
|
|||
| _text = Localize(nameof(Text)); | |||
There was a problem hiding this comment.
See how things got simpler after LocalizableComponent ;)
|
@hishamco ActionLink is broken after this PR.
|
|
Of course, coz you merge this early, I was waiting to merge the localizable component, so I can rebase. If you remember I added an extra commit with out react to the changes I will fix this now ... |
|
Oops... my apologies! |
|
No problem, I will send a PR soon, and continue with other components |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.