Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Return URL for ModuleActions -> Settings should contain URL parameters #4628

Closed
mdmontesinos opened this issue Sep 18, 2024 · 5 comments

Comments

@mdmontesinos
Copy link
Contributor

Oqtane Info

Version - 5.2.2
Render Mode - Static
Interactivity - Server
Database - SQL Server

Describe the enhancement

Currently, if you go into Edit Mode and access the settings when in a page with url parameters, the return url does not contain the parameters, so it's a great inconvenience for content managers.

For example, if I am in a page "news/!/the-latest-news" and I enter the module settings (Edit Mode -> Module Actions -> Settings), after saving or cancelling, I will be returned to "news?edit=true". This is really annoying when editing many pages, as perhaps the setting I changed only can be visualized when the page has that parameter. In that case, I need to again navigate back to parametrized page.

Therefore, the return url should also contain the page parameters and query.

sbwalker added a commit that referenced this issue Sep 18, 2024
fix #4628 - preserve ReturnUrl when navigating to Settings component
@mdmontesinos
Copy link
Contributor Author

@sbwalker Thanks, it's working as expected!

@mdmontesinos
Copy link
Contributor Author

@sbwalker This should actually be applied for all module actions, as trying to move, unpublish, delete, etc, also results in losing the page url parameters.

sbwalker added a commit to sbwalker/oqtane.framework that referenced this issue Sep 19, 2024
sbwalker added a commit that referenced this issue Sep 19, 2024
fix #4628 - preserve Url for all ModuleActions
@sbwalker
Copy link
Member

@mdmontesinos #4640 fixes this for all module actions

@mdmontesinos
Copy link
Contributor Author

@sbwalker It's working fine, but several parameters are being duplicated in the url:

?edit=false&refresh=true&edit=true&refresh

@sbwalker
Copy link
Member

@mdmontesinos I know why that is happening... I will resolve today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants