Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampersand in module description causes failure to load projects #3231

Closed
W6HBR opened this issue Sep 7, 2023 · 4 comments
Closed

Ampersand in module description causes failure to load projects #3231

W6HBR opened this issue Sep 7, 2023 · 4 comments

Comments

@W6HBR
Copy link
Contributor

W6HBR commented Sep 7, 2023

The inclusion of the ampersand in a module description causes each project of the solution to fail to load.
Example description: "Lookup & reporting module".

Trying to manually load the project will return the error:
The project file could not be loaded. An error occurred while parsing EntityName. Line 8, position 32.

Manually editing the project file and changing the offending character will resolve the issue.

@thabaum
Copy link
Contributor

thabaum commented Sep 7, 2023

Have you tested using & instead of & see if it works?

@sbwalker
Copy link
Member

sbwalker commented Sep 8, 2023

@W6HBR Thank you for reporting. The fields in the module and theme creator will either need validation or encoding to prevent this from happening.

@W6HBR
Copy link
Contributor Author

W6HBR commented Sep 8, 2023

@thabaum
Yes, that does work, but it wouldn't be intuitive for people to type their description that way. It needs to be encoded before saving.

sbwalker added a commit that referenced this issue Sep 20, 2023
fix #3231 - validate module description
@sbwalker
Copy link
Member

@W6HBR the *.csproj file is an XML file so rather than encoding invalid XML characters I opted to validate the field and only allow alphanumeric characters and spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants