Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in Module templates #1530

Closed
leigh-pointer opened this issue Jul 3, 2021 · 3 comments
Closed

Error in Module templates #1530

leigh-pointer opened this issue Jul 3, 2021 · 3 comments

Comments

@leigh-pointer
Copy link
Contributor

The Get public Models.[Module] Get(int id) method in the [Module]Controller has an incorrect IF statement which in turn returns nothing and logs an error

if ([Module] != null && [Module].ModuleId != AuthEntityId(EntityNames.Module))

the statement should be

if ([Module] != null && [Module].ModuleId == AuthEntityId(EntityNames.Module))
@sbwalker
Copy link
Member

sbwalker commented Jul 3, 2021

Please submit a PR

@leigh-pointer
Copy link
Contributor Author

@sbwalker done

@leigh-pointer
Copy link
Contributor Author

Added the correct operator.

sbwalker added a commit that referenced this issue Jul 5, 2021
@sbwalker
Merge pull request #1531 from leigh-pointer/ModuleTemplates
910630c 
Fix for #1530 Error in Module templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbwalker @leigh-pointer