Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Renamed decide hook from useDecide to useDecision #105

Merged
merged 1 commit into from
Mar 5, 2021
Merged

refactor: Renamed decide hook from useDecide to useDecision #105

merged 1 commit into from
Mar 5, 2021

Conversation

zashraf1985
Copy link
Contributor

Summary

Renamed decide hook from useDecide to useDecision.

Test Plan

  1. Manually tested thoroughly.
  2. Updated unit tests.

@zashraf1985 zashraf1985 removed their assignment Mar 5, 2021
@zashraf1985 zashraf1985 requested review from jaeopt and yavorona March 5, 2021 20:27
yavorona
yavorona approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@yavorona yavorona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jaeopt
jaeopt approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zashraf1985 zashraf1985 merged commit 2cc2b28 into master Mar 5, 2021
@zashraf1985 zashraf1985 deleted the zeeshan/rename-decide-hook branch March 5, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavorona yavorona yavorona approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zashraf1985 @yavorona @jaeopt