Export OptimizelyReactSDKClient as interface or type

[kylemh]

The return value of createInstance (OptimizelyReactSDKClient) should be exported as a type, lest we need to use ReturnType<typeof createInstance>

[avifoxi]

@kylemh it is ->

import { ReactSDKClient } from '@optimizely/react-sdk'

https://github.com/optimizely/react-sdk/blob/master/src/index.ts#L26

[kylemh]

@avifoxi

No, I mean OptimizelyReactSDKClient which extends off of ReactSDKClient and is the explicit return type for createInstance:

react-sdk/src/client.ts

Line 670 in 6e6f1b4

export function createInstance(config: optimizely.Config): OptimizelyReactSDKClient {

[matthewbordas]

I agree. I ran into this issue this week. It would be really helpful to have this updated!

[zashraf1985]

@kylemh @matthewbordas !
OptimizelyReactSDKClient is the implementation class which shouldn't have been exposed in the first place. We have changed the return type of createInstance to ReactSDKClient, which is already exported by the SDK. Let us know if it resolves your issue?

[kylemh]

I am no longer at the company that had the codebase with this issue, so I won't be able to confirm for you, but I bet it works great!