Skip to content

Commit

Permalink
fix: React SDK null client handling (#149)
Browse files Browse the repository at this point in the history
# Summary

Handle React SDK fail catching if ._client returns null when creating new ReactClientSDK instance from `createInstance` function.

# Test Plan

Manually tested thoroughly.
All existing unit tests pass.

# Issues
#134
  • Loading branch information
opti-jnguyen authored Feb 28, 2022
1 parent 49ba62d commit 1663d01
Show file tree
Hide file tree
Showing 5 changed files with 775 additions and 69 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

- fixed issue [#121](https://github.com/optimizely/react-sdk/issues/121):`ActivateListenerPayload` and `TrackListenerPayload` types were exported from `@optimizely/optimizely-sdk` but were missing from `@optimizely/react-sdk` exports. ([#150](https://github.com/optimizely/react-sdk/pull/150)).

### Bug fixes
- Fixed issue [#134](https://github.com/optimizely/react-sdk/issues/134) of the React SDK crashing when the internal Optimizely client returns as a null value. [PR #149](https://github.com/optimizely/react-sdk/pull/149)

## [2.8.0] - January 26, 2022

### New Features
Expand Down
Loading

0 comments on commit 1663d01

Please sign in to comment.