fix(datafile manager): Node datafile requests use gzip,deflate compression

README.md

@@ -27,3 +27,36 @@ This repository is a monorepo that we manage using [Lerna](https://github.com/le
 ### Contributing
 
 Please see [CONTRIBUTING](CONTRIBUTING.md).
+
+## Credits
+
+First-party code (under `packages/optimizely-sdk/lib/`, `packages/datafile-manager/lib`, `packages/datafile-manager/src`, `packages/datafile-manager/__test__`, `packages/event-processor/src`, `packages/event-processor/__tests__`, `packages/logging/src`, `packages/logging/__tests__`, `packages/utils/src`, `packages/utils/__tests__`) is copyright Optimizely, Inc. and contributors, licensed under Apache 2.0.
+
+## Additional Code
+
+Prod dependencies are as follows:
+
+```json
+{
+  "[email protected]": {
+    "licenses": [
+      "AFLv2.1",
+      "BSD"
+    ],
+    "publisher": "Kris Zyp",
+    "repository": "https://github.com/kriszyp/json-schema"
+  },
+  "[email protected]": {
+    "licenses": "MIT*",
+    "repository": "https://github.com/perezd/node-murmurhash"
+  },
+  "[email protected]": {
+    "licenses": "MIT",
+    "repository": "https://github.com/kelektiv/node-uuid"
+  },
+  "[email protected]": {
+    "licenses": "MIT",
+    "repository": "https://github.com/sindresorhus/decompress-response"
+  }
+}
+```

packages/datafile-manager/CHANGELOG.md

@@ -9,6 +9,11 @@ Changes that have landed but are not yet released.
 
 ### Breaking Changes
 - Removed `StaticDatafileManager` from all top level exports
+- Dropped support for Node.js version <8
+
+### Fixed
+
+- Node datafile manager requests use gzip,deflate compression
 
 ## [0.4.0] - June 12, 2019
 

packages/datafile-manager/README.md

@@ -2,6 +2,14 @@
 
 This package provides datafile manager implementations for Node.js, browsers, and React Native.
 
+## Requirements
+In general, an ES5-compatible environment is required, as well as `Promise` (must be polyfilled if absent).
+
+Platform-specific minimum supported versions:
+
+- Node.js: `8`
+- React Native: `0.61.5`
+
 ## Installation
 
 ```sh

packages/datafile-manager/__test__/nodeRequest.spec.ts

@@ -15,6 +15,7 @@
  */
 
 import nock from 'nock';
+import zlib from 'zlib';
 import { makeGetRequest } from '../src/nodeRequest';
 import { advanceTimersByTime } from './testUtils';
 
@@ -80,6 +81,20 @@ describe('nodeEnvironment', () => {
       scope.done();
     });
 
+    it('adds an Accept-Encoding request header and unzips a gzipped response body', async () => {
+      const scope = nock(host)
+        .matchHeader('accept-encoding', 'gzip,deflate')
+        .get(path)
+        .reply(200, () => zlib.gzipSync('{"foo":"bar"}'), { 'content-encoding': 'gzip' });
+      const req = makeGetRequest(`${host}${path}`, {});
+      const resp = await req.responsePromise;
+      expect(resp).toMatchObject({
+        statusCode: 200,
+        body: '{"foo":"bar"}',
+      });
+      scope.done();
+    });
+
     it('includes headers from the response in the eventual response in the return value', async () => {
       const scope = nock(host)
         .get(path)

packages/datafile-manager/package.json

@@ -44,7 +44,8 @@
   },
   "dependencies": {
     "@optimizely/js-sdk-logging": "^0.1.0",
-    "@optimizely/js-sdk-utils": "^0.2.0"
+    "@optimizely/js-sdk-utils": "^0.2.0",
+    "decompress-response": "^4.2.1"
   },
   "peerDependencies": {
     "@react-native-community/async-storage": "^1.2.0"

packages/datafile-manager/src/nodeRequest.ts

@@ -19,6 +19,7 @@ import https from 'https';
 import url from 'url';
 import { Headers, AbortableRequest, Response } from './http';
 import { REQUEST_TIMEOUT_MS } from './config';
+import decompressResponse from 'decompress-response';
 
 // Shared signature between http.request and https.request
 type ClientRequestCreator = (options: http.RequestOptions) => http.ClientRequest;
@@ -74,16 +75,18 @@ function getResponseFromRequest(request: http.ClientRequest): Promise<Response>
         return;
       }
 
-      incomingMessage.setEncoding('utf8');
+      const response = decompressResponse(incomingMessage);
+
+      response.setEncoding('utf8');
 
       let responseData = '';
-      incomingMessage.on('data', (chunk: string) => {
+      response.on('data', (chunk: string) => {
         if (!request.aborted) {
           responseData += chunk;
         }
       });
 
-      incomingMessage.on('end', () => {
+      response.on('end', () => {
         if (request.aborted) {
           return;
         }
@@ -131,7 +134,10 @@ export function makeGetRequest(reqUrl: string, headers: Headers): AbortableReque
   const requestOptions: http.RequestOptions = {
     ...getRequestOptionsFromUrl(parsedUrl),
     method: 'GET',
-    headers,
+    headers: {
+      ...headers,
+      'accept-encoding': 'gzip,deflate',
+    },
   };
 
   const request = requester(requestOptions);

packages/optimizely-sdk/README.md

@@ -96,23 +96,17 @@ Prod dependencies are as follows:
     "publisher": "Kris Zyp",
     "repository": "https://github.com/kriszyp/json-schema"
   },
-  "[email protected]": {
-    "licenses": "MIT",
-    "publisher": "John-David Dalton",
-    "repository": "https://github.com/lodash/lodash"
-  },
   "[email protected]": {
     "licenses": "MIT*",
     "repository": "https://github.com/perezd/node-murmurhash"
   },
-  "[email protected]": {
-    "licenses": "BSD-3-Clause",
-    "publisher": "Moritz Peters",
-    "repository": "https://github.com/maritz/node-sprintf"
-  },
-  "[email protected]": {
+  "[email protected]": {
     "licenses": "MIT",
     "repository": "https://github.com/kelektiv/node-uuid"
+  },
+  "[email protected]": {
+    "licenses": "MIT",
+    "repository": "https://github.com/sindresorhus/decompress-response"
   }
 }
 ```