Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type for close #410

Merged
merged 3 commits into from
Feb 21, 2020
Merged

Fix return type for close #410

merged 3 commits into from
Feb 21, 2020

Conversation

sumanbh
Copy link
Contributor

@sumanbh sumanbh commented Feb 20, 2020

Summary

  • optimizely.close() does return a Promise. See here
  • Docs also mentions awaiting on close

Fixes 'await' has no effect on the type of this expression.ts(80007)

@sumanbh sumanbh requested a review from a team as a code owner February 20, 2020 15:08
@coveralls
Copy link

coveralls commented Feb 20, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.559% when pulling bceef5f on sumanbh:update-type-close into 7994910 on optimizely:master.

mjc1283
mjc1283 reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@mjc1283 mjc1283 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sumanbh, thanks for fixing this. Would you please sign our CLA as described here? After that I'll be happy to merge this.

@sumanbh
Copy link
Contributor Author

sumanbh commented Feb 21, 2020

@mjc1283 Done.

@mjc1283 mjc1283 merged commit ab7e371 into optimizely:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

Assignees

@sumanbh sumanbh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumanbh @coveralls @mjc1283