Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-11125] implement CMAB client #1010

Merged
merged 4 commits into from
Mar 5, 2025
Merged

[FSSDK-11125] implement CMAB client #1010

merged 4 commits into from
Mar 5, 2025

Conversation

raju-opti
Copy link
Contributor

Summary

Test plan

  • added new tests

Issues

  • FSSDK-11125

@raju-opti raju-opti requested a review from jaeopt February 26, 2025 23:46
@raju-opti raju-opti assigned jaeopt and unassigned raju-opti Feb 26, 2025
@coveralls
Copy link

coveralls commented Feb 26, 2025 •
edited
Loading

Coverage Status

coverage: 82.055% (+0.003%) from 82.052%
when pulling f4e3a1f on raju/cmab_client
into 6861f65 on master.

jaeopt
jaeopt requested changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some suggestions about terms. Let me know if not happy with the new terms :)

@raju-opti raju-opti requested a review from jaeopt March 5, 2025 18:23
jaeopt
jaeopt approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raju-opti raju-opti merged commit a4c27a2 into master Mar 5, 2025
10 of 15 checks passed
@raju-opti raju-opti deleted the raju/cmab_client branch March 5, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @jaeopt