update acceptance tests

optimizely · Aug 21, 2024 · 51f5c8a · 51f5c8a
1 parent 3e50585
commit 51f5c8a
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 4 deletions.
diff --git a/pkg/handlers/decide.go b/pkg/handlers/decide.go
@@ -123,7 +123,7 @@ func Decide(w http.ResponseWriter, r *http.Request) {
 		key := keys[0]
 		logger.Debug().Str("featureKey", key).Msg("fetching feature decision")
 		d := optimizelyUserContext.Decide(key, decideOptions)
-		decideOut := DecideOut{d, d.Variables.ToMap(), IsEveryoneElseVariation(featureMap[d.FlagKey].DeliveryRules, d.RuleKey)}
+		decideOut := DecideOut{d, d.Variables.ToMap(), isEveryoneElseVariation(featureMap[d.FlagKey].DeliveryRules, d.RuleKey)}
 		render.JSON(w, r, decideOut)
 		return
 	default:
@@ -133,7 +133,7 @@ func Decide(w http.ResponseWriter, r *http.Request) {
 
 	decideOuts := []DecideOut{}
 	for _, d := range decides {
-		decideOut := DecideOut{d, d.Variables.ToMap(), IsEveryoneElseVariation(featureMap[d.FlagKey].DeliveryRules, d.RuleKey)}
+		decideOut := DecideOut{d, d.Variables.ToMap(), isEveryoneElseVariation(featureMap[d.FlagKey].DeliveryRules, d.RuleKey)}
 		decideOuts = append(decideOuts, decideOut)
 		logger.Debug().Msgf("Feature %q is enabled for user %s? %t", d.FlagKey, d.UserContext.UserID, d.Enabled)
 	}
@@ -154,7 +154,7 @@ func getUserContextWithOptions(r *http.Request) (DecideBody, error) {
 	return body, nil
 }
 
-func IsEveryoneElseVariation(rules []config.OptimizelyExperiment, ruleKey string) bool {
+func isEveryoneElseVariation(rules []config.OptimizelyExperiment, ruleKey string) bool {
 	for _, r := range rules {
 		if r.Key == ruleKey {
 			return r.Key == r.ID && strings.HasPrefix(r.Key, DefaultRolloutPrefix)

diff --git a/tests/acceptance/test_acceptance/test_decide.py b/tests/acceptance/test_acceptance/test_decide.py
@@ -12,6 +12,7 @@
     "enabled": True,
     "ruleKey": "",
     "flagKey": "feature_2",
+    "isEveryoneElseVariation": False,
     "userContext": {
         "userId": "matjaz",
         "attributes": {
@@ -26,6 +27,7 @@
     "enabled": True,
     "ruleKey": "feature_2_test",
     "flagKey": "feature_2",
+    "isEveryoneElseVariation": False,
     "userContext": {
         "userId": "matjaz",
         "attributes": {
@@ -43,6 +45,7 @@
       "enabled": true,
       "ruleKey": "feature_2_test",
       "flagKey": "feature_2",
+      "isEveryoneElseVariation": False,
       "userContext": {
         "userId": "matjaz",
         "attributes": {
@@ -59,6 +62,7 @@
       "enabled": true,
       "ruleKey": "feature_2_test",
       "flagKey": "feature_2",
+      "isEveryoneElseVariation": False,
       "userContext": {
         "userId": "matjaz",
         "attributes": {
@@ -75,6 +79,7 @@
       "enabled": false,
       "ruleKey": "",
       "flagKey": "invalid_flag_key",
+      "isEveryoneElseVariation": False,
       "userContext": {
         "userId": "matjaz",
         "attributes": {

diff --git a/tests/acceptance/test_acceptance/test_odp_decide.py b/tests/acceptance/test_acceptance/test_odp_decide.py
@@ -12,6 +12,7 @@
     "enabled": False,
     "ruleKey": "default-rollout-52207-23726430538",
     "flagKey": "flag1",
+    "isEveryoneElseVariation": True,
     "userContext": {
         "userId": "matjaz-user-1",
         "attributes": {}
@@ -28,6 +29,7 @@
     "enabled": False,
     "ruleKey": "default-rollout-52207-23726430538",
     "flagKey": "flag1",
+    "isEveryoneElseVariation": True,
     "userContext": {
         "userId": "test_user",
         "attributes": {}
@@ -44,6 +46,7 @@
     "enabled": True,
     "ruleKey": "ab_experiment",
     "flagKey": "flag1",
+    "isEveryoneElseVariation": False,
     "userContext": {
         "userId": "matjaz-user-1",
         "attributes": {}
@@ -56,6 +59,7 @@
     "enabled": False,
     "ruleKey": "default-rollout-52231-23726430538",
     "flagKey": "flag2",
+    "isEveryoneElseVariation": True,
     "userContext": {
         "userId": "matjaz-user-1",
         "attributes": {}

diff --git a/tests/acceptance/test_acceptance/test_odp_redis.py b/tests/acceptance/test_acceptance/test_odp_redis.py
@@ -14,6 +14,7 @@
     "enabled": True,
     "ruleKey": "ab_experiment",
     "flagKey": "flag1",
+    "isEveryoneElseVariation": False,
     "userContext": {
         "userId": "matjaz-user-1",
         "attributes": {}
@@ -26,6 +27,7 @@
     "enabled": True,
     "ruleKey": "ab_experiment",
     "flagKey": "flag1",
+    "isEveryoneElseVariation": False,
     "userContext": {
         "userId": "matjaz-user-2",
         "attributes": {}
@@ -38,6 +40,7 @@
     "enabled": True,
     "ruleKey": "ab_experiment",
     "flagKey": "flag1",
+    "isEveryoneElseVariation": False,
     "userContext": {
         "userId": "matjaz-user-4",
         "attributes": {}

diff --git a/tests/acceptance/test_acceptance/test_ups.py b/tests/acceptance/test_acceptance/test_ups.py
@@ -25,6 +25,7 @@ def test_ups__feature(session_obj):
         {
           "variationKey": "variation_1",
           "enabled": true,
+          "isEveryoneElseVariation": False,
           "ruleKey": "feature_2_test",
           "flagKey": "feature_2",
           "userContext": {
@@ -98,6 +99,7 @@ def test_ups__save(session_obj):
             "variationKey": "variation_2",
             "enabled": true,
             "ruleKey": "feature_2_test",
+            "isEveryoneElseVariation": False,
             "flagKey": "feature_2",
             "userContext": {
                 "userId": "user1",
@@ -186,7 +188,8 @@ def test_ups__save_with_invalid_payload(session_obj):
                     "attr_1": "hola"
                 }
             },
-            "reasons": []
+            "reasons": [],
+            "isEveryoneElseVariation": False
         }
     """