Run CI tests against multiple versions #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## stable #246 +/- ##
==========================================
- Coverage 70.28% 70.25% -0.04%
==========================================
Files 82 82
Lines 7462 7477 +15
Branches 1385 1387 +2
==========================================
+ Hits 5245 5253 +8
- Misses 1842 1849 +7
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more.
|
LucasG0
force-pushed
the
lgu-ci-tests
branch
25 times, most recently
from
f69736f to
212da2c
Compare
LucasG0
changed the title
ogenstad
reviewed
Jan 24, 2025
| INFRAHUB_VERSION = os.getenv("INFRAHUB_TESTING_IMAGE_VER", "latest") | ||
|
|
||
|
|
||
| def skip_version(min_infrahub_version: str | None = None, max_infrahub_version: str | None = None) -> bool: |
There was a problem hiding this comment.
When is it that this skip_version function gets used?
There was a problem hiding this comment.
Whenever a SDK test should be running prior/since a given infrahub version. We do not have such tests for now, but should have some in the future
dgarros
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables CI tests to run against both latest infrahub server version and local version of stable/develop branch. Version is set using
INFRAHUB_TESTING_IMAGE_VERenvironment variable (that we already use within python_testcontainers, and related logic should be simplified when this PR is cleaned/finalized).Ideally, we would also like to have an
---infrahub-versioncli argument for users convenience. Adding such a parameter requires to definepytest_adoptionwithin aconftest.pyfile. However, having thisconftest.pybeing loaded when a user runs a test requires either of the tests to be located in the same folder/subfolders ofconftest.py- and it should not be the case. So, we need a more elaborated pytest plugin/hook mechanism that would deserve a dedicated PR.Note that we may later want to run sdk tests at least against pinned major infrahub versions.