InfrahubCTL: Repository command changes #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion in favor of ref option to match API and allow setting the ref on CTL.
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## stable #244 +/- ##
=======================================
Coverage 70.28% 70.29%
=======================================
Files 82 82
Lines 7462 7463 +1
Branches 1385 1386 +1
=======================================
+ Hits 5245 5246 +1
Misses 1842 1842
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -70,7 +70,7 @@ async def add( | |||
| description: str = "", | |||
| username: str | None = None, | |||
| password: str = "", | |||
| commit: str = "", | |||
| ref: str = "", | |||
There was a problem hiding this comment.
Do we need to keep commit but make it mutually exclusive with ref?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow us to set the ref which is used to define what release/branch/commit to uae
committorefoption and update code to reflect the same (Breaking Change)Is
commitsupposed to be an available field to update or one that gets set on synchronization?