Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align environment variables between the SDK and infrahubctl #243

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

wvandeun
Copy link
Contributor

infrahuctl was using other environment variables to achieve the same goal as other envrionment variables that we leverage in the SDK. This PR aligns the usage of them.

INFRAHUBCTL_TIMEOUT > INFRAHUB_TIMEOUT
INFRAHUBCTL_CONCURRENT_EXECUTION > INFRAHUBCTL_MAX_CONCURRENT_EXECUTION

@wvandeun wvandeun self-assigned this Jan 17, 2025
@wvandeun wvandeun force-pushed the wvd-20250116-remove-infrahubctl-env-vars branch from b821fb0 to eebc246 Compare January 17, 2025 16:19
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ There is a different number of reports uploaded between BASE (5f73796) and HEAD (9abe527). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (5f73796) HEAD (9abe527)
python-3.12 1 0
python-3.9 1 0
python-3.10 1 0
python-filler-3.12 1 0
python-3.11 1 0
@@             Coverage Diff              @@
##           develop     #243       +/-   ##
============================================
- Coverage    70.28%   48.85%   -21.44%     
============================================
  Files           82       82               
  Lines         7462     7463        +1     
  Branches      1385     1383        -2     
============================================
- Hits          5245     3646     -1599     
- Misses        1842     3530     +1688     
+ Partials       375      287       -88     
Flag Coverage Δ
integration-tests 22.45% <0.00%> (-0.01%) ⬇️
python-3.10 ?
python-3.11 ?
python-3.12 ?
python-3.13 45.49% <100.00%> (+<0.01%) ⬆️
python-3.9 ?
python-filler-3.12 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/cli_commands.py 58.82% <ø> (ø)
infrahub_sdk/ctl/exporter.py 50.00% <ø> (ø)
infrahub_sdk/ctl/importer.py 57.14% <100.00%> (+2.14%) ⬆️

... and 43 files with indirect coverage changes

@wvandeun wvandeun force-pushed the wvd-20250116-remove-infrahubctl-env-vars branch from eebc246 to ebb5d10 Compare January 20, 2025 08:29
INFRAHUBCTL_TIMEOUT > INFRAHUB_TIMEOUT
INFRAHUBCTL_CONCURRENT_EXECUTION > INFRAHUBCTL_MAX_CONCURRENT_EXECUTION
@wvandeun wvandeun force-pushed the wvd-20250116-remove-infrahubctl-env-vars branch from ebb5d10 to 9abe527 Compare January 20, 2025 08:33
@wvandeun wvandeun merged commit 34e3cd5 into develop Jan 20, 2025
14 checks passed
@wvandeun wvandeun deleted the wvd-20250116-remove-infrahubctl-env-vars branch January 20, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants