Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace static joins with f-strings #242

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Replace static joins with f-strings #242

merged 1 commit into from
Jan 17, 2025

Conversation

ogenstad
Copy link
Contributor

Activates FLY rules for ruff.

Activates FLY rules for ruff.
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/pytest_plugin/items/graphql_query.py 0.00% 1 Missing ⚠️
...frahub_sdk/pytest_plugin/items/python_transform.py 0.00% 1 Missing ⚠️
@@           Coverage Diff            @@
##           develop     #242   +/-   ##
========================================
  Coverage    70.28%   70.28%           
========================================
  Files           82       82           
  Lines         7462     7462           
  Branches      1385     1385           
========================================
  Hits          5245     5245           
  Misses        1842     1842           
  Partials       375      375           
Flag Coverage Δ
integration-tests 22.46% <0.00%> (ø)
python-3.10 45.48% <33.33%> (ø)
python-3.11 45.48% <33.33%> (?)
python-3.12 45.48% <33.33%> (?)
python-3.13 45.48% <33.33%> (ø)
python-3.9 45.48% <33.33%> (?)
python-filler-3.12 24.08% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...frahub_sdk/pytest_plugin/items/jinja2_transform.py 54.79% <100.00%> (ø)
infrahub_sdk/pytest_plugin/items/graphql_query.py 48.48% <0.00%> (ø)
...frahub_sdk/pytest_plugin/items/python_transform.py 39.21% <0.00%> (ø)

@ogenstad ogenstad marked this pull request as ready for review January 17, 2025 11:02
@ogenstad ogenstad requested a review from a team January 17, 2025 11:02
@ogenstad ogenstad merged commit fd6e5f6 into develop Jan 17, 2025
14 checks passed
@ogenstad ogenstad deleted the pog-ruff-fly branch January 17, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants