Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add count method to clients #225

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Add count method to clients #225

merged 3 commits into from
Jan 8, 2025

Conversation

gmazoyer
Copy link
Contributor

@gmazoyer gmazoyer commented Jan 8, 2025

Fixes #158

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/client.py 71.42% 2 Missing and 2 partials ⚠️
@@           Coverage Diff            @@
##           develop     #225   +/-   ##
========================================
  Coverage    68.03%   68.03%           
========================================
  Files           82       82           
  Lines         7370     7384   +14     
  Branches      1440     1442    +2     
========================================
+ Hits          5014     5024   +10     
- Misses        1984     1986    +2     
- Partials       372      374    +2     
Flag Coverage Δ
integration-tests 12.98% <0.00%> (-0.03%) ⬇️
python-3.10 43.29% <57.14%> (+0.02%) ⬆️
python-3.11 43.29% <57.14%> (+0.02%) ⬆️
python-3.12 43.29% <57.14%> (+0.02%) ⬆️
python-3.13 43.29% <57.14%> (+0.02%) ⬆️
python-3.9 41.73% <57.14%> (+0.02%) ⬆️
python-filler-3.12 24.05% <14.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/client.py 64.07% <71.42%> (+0.12%) ⬆️

@gmazoyer gmazoyer marked this pull request as ready for review January 8, 2025 10:33
@gmazoyer gmazoyer requested a review from a team January 8, 2025 10:42
@gmazoyer gmazoyer merged commit 60d001e into develop Jan 8, 2025
14 checks passed
@gmazoyer gmazoyer deleted the gma-20250108-158 branch January 8, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: add count method to InfrahubClient
2 participants