Order of retrieved nodes can be disabled #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #223 +/- ##
===========================================
- Coverage 68.72% 68.70% -0.03%
===========================================
Files 82 82
Lines 7515 7525 +10
Branches 1459 1462 +3
===========================================
+ Hits 5165 5170 +5
- Misses 1972 1975 +3
- Partials 378 380 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dgarros
reviewed
Jan 7, 2025
infrahub_sdk/types.py
Outdated
| @@ -64,3 +66,7 @@ def exception(self, event: str | None = None, *args: Any, **kw: Any) -> Any: | |||
|
|
|||
|
|
|||
| InfrahubLoggers = Union[InfrahubLogger, Logger] | |||
|
|
|||
|
|
|||
| class OrderModel(BaseModel): | |||
There was a problem hiding this comment.
I think we should call it just Order to keep it simpler for the user and easier to read
|
Please can you add an entry in the changelog directory to include something in the release note |
LucasG0
force-pushed
the
lgu-add-order-disable
branch
from
4e18000 to
ffd8384
Compare
LucasG0
force-pushed
the
lgu-add-order-disable
branch
2 times, most recently
from
561614b to
d92173d
Compare
LucasG0
force-pushed
the
lgu-add-order-disable
branch
from
d92173d to
9b1fe7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.