Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds infrahubctl info command #208

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Adds infrahubctl info command #208

merged 1 commit into from
Jan 9, 2025

Conversation

minitriga
Copy link
Contributor

@minitriga minitriga commented Jan 3, 2025

Fixes: #109
Screenshot 2025-01-03 at 16 43 55

Detail View
Screenshot 2025-01-03 at 16 44 15

Error state
Screenshot 2025-01-03 at 16 44 41

@dgarros shall I add recommendations based on AuthenticationError and ServerNotReachableError

Something like: Please check api key or username/password and Ensure you have the correct infrahub address defined?

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 98.97959% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/ctl/cli_commands.py 98.41% 0 Missing and 1 partial ⚠️
@@             Coverage Diff             @@
##           develop     #208      +/-   ##
===========================================
+ Coverage    68.21%   68.72%   +0.51%     
===========================================
  Files           82       82              
  Lines         7424     7515      +91     
  Branches      1446     1459      +13     
===========================================
+ Hits          5064     5165     +101     
+ Misses        1986     1974      -12     
- Partials       374      376       +2     
Flag Coverage Δ
integration-tests 12.86% <0.00%> (-0.16%) ⬇️
python-3.10 44.31% <88.77%> (+0.70%) ⬆️
python-3.11 44.31% <88.77%> (+0.70%) ⬆️
python-3.12 44.31% <88.77%> (+0.70%) ⬆️
python-3.13 44.31% <88.77%> (+0.70%) ⬆️
python-3.9 41.96% <34.69%> (-0.07%) ⬇️
python-filler-3.12 23.73% <10.20%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/client.py 66.89% <100.00%> (+1.13%) ⬆️
infrahub_sdk/queries.py 50.00% <100.00%> (+7.14%) ⬆️
infrahub_sdk/utils.py 76.76% <100.00%> (+1.49%) ⬆️
infrahub_sdk/ctl/cli_commands.py 58.82% <98.41%> (+13.64%) ⬆️

... and 3 files with indirect coverage changes

@dgarros
Copy link
Contributor

dgarros commented Jan 3, 2025

Thanks @minitriga
I think we could remove the groups from the summary view and add the username instead.

@minitriga minitriga changed the title Adds infrahubctl info command WIP: Adds infrahubctl info command Jan 3, 2025
@minitriga
Copy link
Contributor Author

I will also add some unit tests to cover infrahubctl version/info commands.

@minitriga minitriga changed the title WIP: Adds infrahubctl info command Adds infrahubctl info command Jan 3, 2025
@dgarros dgarros force-pushed the atg-20250103-ihs-55 branch from 8622520 to 40214b1 Compare January 9, 2025 05:15
Co-authored-by: Alex Gittings <[email protected]>
@dgarros dgarros force-pushed the atg-20250103-ihs-55 branch from 40214b1 to 25e99a4 Compare January 9, 2025 05:18
@dgarros dgarros merged commit 5f28683 into develop Jan 9, 2025
14 checks passed
@dgarros dgarros deleted the atg-20250103-ihs-55 branch January 9, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: infrahubctl info command
2 participants