Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behavior of include to only include the requested fields #205

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dgarros
Copy link
Contributor

@dgarros dgarros commented Jan 2, 2025

Fixes #192

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop     #205      +/-   ##
===========================================
- Coverage    68.03%   64.71%   -3.33%     
===========================================
  Files           82       82              
  Lines         7370     7368       -2     
  Branches      1440     1439       -1     
===========================================
- Hits          5014     4768     -246     
- Misses        1984     2222     +238     
- Partials       372      378       +6     
Flag Coverage Δ
integration-tests ?
python-3.10 43.30% <100.00%> (+0.03%) ⬆️
python-3.11 43.30% <100.00%> (+0.03%) ⬆️
python-3.12 43.30% <100.00%> (+0.03%) ⬆️
python-3.13 43.30% <100.00%> (+0.03%) ⬆️
python-3.9 41.69% <100.00%> (-0.02%) ⬇️
python-filler-3.12 24.07% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/node.py 73.46% <100.00%> (-4.28%) ⬇️

... and 8 files with indirect coverage changes

@dgarros dgarros requested a review from a team January 2, 2025 18:24
@dgarros dgarros marked this pull request as ready for review January 2, 2025 18:24
@dgarros dgarros force-pushed the dga-20250102-include branch from 53fa7a3 to 74bad3b Compare January 5, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task: Change behavior of include to only include the requested fields
3 participants