Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove task_report.py #143

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Remove task_report.py #143

merged 1 commit into from
Jan 15, 2025

Conversation

LucasG0
Copy link
Contributor

@LucasG0 LucasG0 commented Nov 15, 2024

Related to IFC-917

@LucasG0 LucasG0 requested a review from a team November 15, 2024 10:40
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop     #143      +/-   ##
===========================================
+ Coverage    69.43%   70.25%   +0.81%     
===========================================
  Files           83       82       -1     
  Lines         7548     7460      -88     
  Branches      1394     1384      -10     
===========================================
  Hits          5241     5241              
+ Misses        1932     1844      -88     
  Partials       375      375              
Flag Coverage Δ
integration-tests 22.46% <ø> (+0.26%) ⬆️
python-3.10 45.44% <ø> (+0.52%) ⬆️
python-3.11 45.44% <ø> (+0.52%) ⬆️
python-3.12 45.44% <ø> (+0.52%) ⬆️
python-3.13 45.44% <ø> (+0.52%) ⬆️
python-3.9 45.44% <ø> (+0.52%) ⬆️
python-filler-3.12 24.08% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ogenstad
Copy link
Contributor

We'd have to create a pipeline for the Infrahub project where we updated the submodule commit to use this branch and verify that it works within Infrahub itself first. I think we're still using this task_report object in a number of places there.

@ogenstad
Copy link
Contributor

There's a merge conflict on this PR, but I think we should be able completely remove the task_report from here now?

# Conflicts:
#	infrahub_sdk/task_report.py
@LucasG0 LucasG0 force-pushed the lgu-remove-task-report branch from ec1d107 to 6c6bd0a Compare January 14, 2025 10:57
@LucasG0 LucasG0 merged commit e018386 into develop Jan 15, 2025
14 checks passed
@LucasG0 LucasG0 deleted the lgu-remove-task-report branch January 15, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants