Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Replace GitPython with dulwich #130

Closed
dgarros opened this issue Nov 7, 2024 · 0 comments · Fixed by #218
Closed

feature: Replace GitPython with dulwich #130

dgarros opened this issue Nov 7, 2024 · 0 comments · Fixed by #218
Labels
type/feature New feature or request type/newcomers Good for newcomers

Comments

@dgarros
Copy link
Contributor

dgarros commented Nov 7, 2024

Component

Python SDK, infrahubctl CLI

Describe the Feature Request

Today, some features related to Git in the python SDK is dependent on having the git binary available on the system but the installation is left to the user.

The proposal is to replace GitPython with the library dulwich.
dulwich is built in pure python and doesn't require the git binary to be available.

Describe the Use Case

Improve the user experience

Additional Information

Related to #16
@dgarros dgarros added type/feature New feature or request type/newcomers Good for newcomers labels Nov 7, 2024
minitriga added a commit that referenced this issue Jan 6, 2025
@minitriga
resolves #130: Replace GitPython with dulwich
772310b
@minitriga minitriga mentioned this issue Jan 6, 2025
Merged
minitriga added a commit that referenced this issue Jan 13, 2025
@minitriga
Resolves #130: Replace GitPython with dulwich (#218)
5d28576 
* resolves #130: Replace GitPython with dulwich

* Remove debugging

* Add better testing for initializing git repos

* Refactor RepoManager

* Add integration test for dulwich

* Add minimum version for dulwich

* Fix linting for exception match

* Add debug for ci

* Move asserts so it fails early

* Add debugging for integration test

* Return docker compose config in CI

* Add more debugs for files

* Run command on docker host

* Get container logs

* Comment out integration test for git repo

* Remove print
@lykinsbd lykinsbd mentioned this issue Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature New feature or request type/newcomers Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolves #130: Replace GitPython with dulwich opsmill/infrahub-sdk-python
1 participant
@dgarros