Feature/kubernetes connector refactor #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependant on kubernetes connector, fix misc type hints, fix conftest errors
scrape failures outside scope of tested code
- further harden against minikube failed start - remove lingering rollout references - update unfinished checks of kubenernetes connector
applying remedies, disable redundant test_checks_timeout_with_halt
tmp_path, fix lingering reference to opsani_dev checks controller_type_name, delete placeholder checks class used during refactor
for container ports instead of None
DanielHHowell
approved these changes
Oct 4, 2022
- Drop redundant and unused imports - Delete outdated TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.