Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set requests=limits if unspecified, do not return metrics if limits u… #426

Merged
merged 9 commits into from
May 6, 2022
Merged

Set requests=limits if unspecified, do not return metrics if limits u… #426

merged 9 commits into from
May 6, 2022

Conversation

DanielHHowell
Copy link
Contributor

…nspecified

@linear
Copy link

linear bot commented May 3, 2022

ENG-916 Unspecified requests/limits handling in kube metrics connector

Currently certain None values are processed through the kube metrics connector (e.g. with unspecified requests) causing a measurement error. In addition to this minor bug fix, there is a desire to treat requests = limits (within the connector) if only limits are specified.

Full case enumeration

  1. Requests specified, limits not: do not return any metrics depending on limits

  2. Limits specified, requests not: set requests equal to limits

  3. Both unspecified: servox will not function regardless

@DanielHHowell DanielHHowell requested a review from linkous8 May 4, 2022 00:22
linkous8
linkous8 approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@linkous8 linkous8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@DanielHHowell DanielHHowell merged commit 06c574e into main May 6, 2022
@DanielHHowell DanielHHowell deleted the danielh/eng-916-unspecified-requestslimits-handling-in branch May 6, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linkous8 linkous8 linkous8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielHHowell @linkous8