Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix k8s permissions check error with rollout #358

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Fix k8s permissions check error with rollout #358

merged 1 commit into from
Nov 4, 2021

Conversation

linkous8
Copy link
Contributor

@linkous8 linkous8 commented Nov 3, 2021

  • Replace list.append with list.extend

@linkous8
Fix k8s permissions check error with rollout
601c603 
- Replace list.append with list.extend
@linear
Copy link

linear bot commented Nov 3, 2021

ENG-566 Servox kubernetes connector permissions check fails if configured for rollouts

Check fails with attribute error resources is not an attribute of List. The issue is I need to use the extend method instead of the append method in the check here:

servox/servo/connectors/kubernetes.py

Line 4400 in 44b1dc2

required_permissions.append(ROLLOUT_PERMISSIONS)

@linkous8 linkous8 merged commit 53befe8 into main Nov 4, 2021
@linkous8 linkous8 deleted the fred/eng-566-servox-kubernetes-connector-permissions branch November 4, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielHHowell DanielHHowell DanielHHowell approved these changes

@blakewatters blakewatters Awaiting requested review from blakewatters

@rstarmer rstarmer Awaiting requested review from rstarmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linkous8 @DanielHHowell