k8s support for static env var config #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-439 K8s connector support for configuration of static environment variable injection into tuning pod
To support @daniel's AppD efforts, the need has been identified to set an environment variable in the tuning pod so that it can be differentiated from the main app pods in the AppD metrics. Given the value of this environment variable does not need to change once applied, this is being implemented as a configuration option for the sake of expediency and will not be exposed for adjustment to the backend/optimizer |
mode - Check env var configuration during DeploymentOptimization.create and raise NotImplementedError if present - Expand test coverage for tuning pod creation - Add static_environment_variables to tuning pod creation tests and validations - Update opsani_dev_test TestConfig.test_generate with static_environment_variables config key - Add opsani_dev_test TestConfig.test_genrate_kubernetes_config including static_environment_variables input and validation
|
Confirming this worked on live tests with the opsani_dev connector and directly in the kubernetes connector. Good to go after merge conflict |
- Update static_environment_variables logic to filter out existing environment variables with same name(s) as configured variables - Expand integration test coverage to verify existing environment variables are overriden by static_environment_variables
DanielHHowell
approved these changes
Oct 11, 2021
linkous8
deleted the
fred/eng-439-k8s-connector-support-for-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.