-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update filterwarnings so test warnings are treated as errors (Fixes ENG-73) #288
Conversation
ENG-73 Warnings fired by tests should cause test failures
Per @blake's request, I've worked on getting test warnings to raise errors instead as time permits since this is fairly low priority/nice to have. The change consists of updating pytest's filterwarnings config to cause all warnings to error then ignore warnings we don't care about:
Currently the above causes the integration test suite to run indefinitely and requires further debug before it can be merged (see branch https://github.com/opsani/servox/tree/bugfix/add-filterwarnings-error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Additional exceptions can always be added if they are found to be needed.
No description provided.