ENG-3 Don't enforce validations when applying values to Kubernetes resource… #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 15, 2021 21:06
linkous8
changed the title
ENG-3 Support out-of-range baseline settings
(P0) Support out-of-range baseline settings. Allow application's baseline settings to have any values, without requiring them to fit our min/max/step range definition (esp. the alignment). This allows us to onboard applications that have any baseline values while keeping our range/step for the suggestions we would make. It removes the unintuitive and onerous requirement to change the app's existing settings of the app fit our desired min/max/step model (which they rarely do). The backend (mostly) supports this already, see verification task and summary implementation tasks |
…ttings - incorporate latest main to allow PR merge
- Update Deployment and Canary optimizations' CPU/mem getters to allow out of range values on describe - Add integration tests coverage for adjusting and describing out of range values
rstarmer
approved these changes
Sep 13, 2021
DanielHHowell
approved these changes
Sep 13, 2021
linkous8
deleted the
blake/eng-3-support-out-of-range-baseline-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… settings. refs ENG-3