Drop p99 metrics from opsani_dev generated config (#306)

* Drop p99 metrics from opsani_dev generated config * Drop p99_latency configuration from test manifest
opsani · Aug 9, 2021 · b65b037 · b65b037
1 parent d4e999a
commit b65b037
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 16 deletions.
diff --git a/servo/connectors/opsani_dev.py b/servo/connectors/opsani_dev.py
@@ -175,16 +175,6 @@ def generate_prometheus_config(
                     query='sum(rate(envoy_cluster_upstream_rq_xx{opsani_role="tuning", envoy_response_code_class=~"4|5"}[1m]))',
                     absent=servo.connectors.prometheus.AbsentMetricPolicy.zero
                 ),
-                servo.connectors.prometheus.PrometheusMetric(
-                    "main_p99_latency",
-                    servo.types.Unit.milliseconds,
-                    query='avg(histogram_quantile(0.99,rate(envoy_cluster_upstream_rq_time_bucket{opsani_role!="tuning"}[1m])))',
-                ),
-                servo.connectors.prometheus.PrometheusMetric(
-                    "tuning_p99_latency",
-                    servo.types.Unit.milliseconds,
-                    query='avg(histogram_quantile(0.99,rate(envoy_cluster_upstream_rq_time_bucket{opsani_role="tuning"}[1m])))',
-                ),
                 servo.connectors.prometheus.PrometheusMetric(
                     "main_p90_latency",
                     servo.types.Unit.milliseconds,

diff --git a/tests/connectors/opsani_dev/prometheus.yaml b/tests/connectors/opsani_dev/prometheus.yaml
@@ -68,12 +68,6 @@ data:
           query: rate(envoy_cluster_upstream_rq_xx{opsani_role="tuning", envoy_response_code_class=~"4|5"}[3m]) OR ON() vector(0)
           unit: rps
 
-        - name: main_p99_latency
-          query: avg(histogram_quantile(0.99,rate(envoy_cluster_upstream_rq_time_bucket{opsani_role!="tuning"}[3m]))) OR ON() vector(0)
-          unit: ms
-        - name: tuning_p99_latency
-          query: avg(histogram_quantile(0.99,rate(envoy_cluster_upstream_rq_time_bucket{opsani_role="tuning"}[3m]))) OR ON() vector(0)
-          unit: ms
         - name: main_p90_latency
           query: avg(histogram_quantile(0.9,rate(envoy_cluster_upstream_rq_time_bucket{opsani_role!="tuning"}[3m]))) OR ON() vector(0)
           unit: ms