MVC - Phalcon 5 migration and options to lose dependency of phalcon v…

…alidation classes.

Minor regression in previous commit, performValidation()'s return type didn't match. Ideally we would rather switch to plain array's, but since performValidation()
is used in multiple areas (including plugins) we better opt for compatiblity now.

ref  #5711

src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php

@@ -447,13 +447,7 @@ public function performValidation($validateFullModel = false)
             }
         }
 
-        if (count($validation_data) > 0) {
-            $messages = $validation->validate($validation_data);
-        } else {
-            $messages = new Messages();
-        }
-
-        return $messages;
+        return $validation->validate($validation_data);
     }
 
     /**

src/opnsense/mvc/app/models/OPNsense/Base/Validation.php

@@ -28,15 +28,18 @@
 
 namespace OPNsense\Base;
 
+use Phalcon\Messages\Messages;
 
 class Validation
 {
     private $validators = [];
-    private $messages = [];
+    private $messages = null;
     public function __construct($validators = [])
     {
         $this->validators = $validators;
         $this->phalcon_validation = new \Phalcon\Validation();
+        $this->messages = new Messages();
+        $this->data = [];
     }
 
     /**
@@ -45,8 +48,7 @@ public function __construct($validators = [])
      */
     public function appendMessage($message)
     {
-        $this->messages[] = $message;
-        $this->data = [];
+        $this->messages->appendMessage($message);
     }
 
     /**