Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OC-1661] Removing inconsistent tooling configuration and changing gr… #956

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

AlexGuironnetRTE
Copy link
Member

@AlexGuironnetRTE AlexGuironnetRTE commented Apr 20, 2021

Node and npm versions were not consistent depending on whether the build was launched using npm from the command line, a local gradle task or the CI build, which could have caused different behaviours/errors depending on the environment.
To fix this I:

  • Updated the travis configuration to rely on the load_environment_light script that is used to set up local dev environments instead of separate configuration
  • Removed the versions from the node plugin configuration in the ui gradle config.

In addition I took this opportunity to switch from the com.moowork.node plugin that doesn't seem to be maintained since early 2019 (see srs/gradle-node-plugin#315) to a community-maintained fork that looks more up-to-date (latest commit in February): https://github.com/node-gradle/gradle-node-plugin
Since it's a fork, I didn't need to make any changes to our existing configuration.

In release notes, under Tasks:

OC-1661: Removing inconsistent tooling configuration and changing gradle node plugin

@vlo-rte vlo-rte self-assigned this Apr 21, 2021
@vlo-rte vlo-rte merged commit e6c432b into develop Apr 21, 2021
@vlo-rte vlo-rte deleted the OC-1661 branch April 21, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants