Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed #827 #830

Merged
merged 1 commit into from
Dec 12, 2018
Merged

fixed #827 #830

merged 1 commit into from
Dec 12, 2018

Conversation

jianzhangbjz
Copy link
Contributor

Description of the change:
Added -update flag to sync the Gopkg.toml toGopkg.lock.

Motivation for the change:
The Gopkg.toml does NOT sync to Gopkg.lock automatically. Correct me if I'm wrong.
But, it will take more time to run if we add this -update flag.
Any comments are welcome！

Closes #827

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2018
@lilic
Copy link
Member

lilic commented Dec 10, 2018 •
edited
Loading

Yes you are right according to the docs:

   -update       update the named dependencies (or all, if none are named) in Gopkg.lock to the latest allowed by Gopkg.toml (default: false)

Weird thing is that dep ensure -v works fine for me, so maybe we can add this as another make target and mention it in the docs, for example make dep-update. WDYT? (Mainly because it takes much longer to run that compared to just dep ensure.)

@estroz
Copy link
Member

estroz commented Dec 10, 2018

@jianzhangbjz I'd rather not use -update in make dep because it has side effects not apparent to users. We keep Gopkg.lock up to date by pushing revendor commits, so Gopkg.lock on master has been confirmed to work by CI, and by myself and @lilic locally. I'm fine with make dep-update.

@estroz estroz self-requested a review December 10, 2018 17:03
estroz
estroz suggested changes Dec 10, 2018
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment

@jianzhangbjz
Copy link
Contributor Author

@lilic @estroz Thank you for your suggestion! Added make dep-update per your comments, please have a review!

AlexNPavel
AlexNPavel approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@AlexNPavel AlexNPavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joelanford
joelanford approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lilic
lilic approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@lilic lilic merged commit 7e70e36 into operator-framework:master Dec 12, 2018
@jianzhangbjz
Copy link
Contributor Author

You're welcome!

@jianzhangbjz jianzhangbjz deleted the dep branch December 13, 2018 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@AlexNPavel AlexNPavel AlexNPavel approved these changes

@lilic lilic lilic approved these changes

@estroz estroz estroz approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build operator-sdk failed
6 participants
@jianzhangbjz @lilic @estroz @joelanford @AlexNPavel @openshift-ci-robot